fix out of bound error in Phase-2 L1 Calorimeter barrel emulator#46471
Closed
skkwan wants to merge 1 commit intocms-sw:CMSSW_14_1_Xfrom
Closed
fix out of bound error in Phase-2 L1 Calorimeter barrel emulator#46471skkwan wants to merge 1 commit intocms-sw:CMSSW_14_1_Xfrom
skkwan wants to merge 1 commit intocms-sw:CMSSW_14_1_Xfrom
Conversation
Contributor
|
A new Pull Request was created by @skkwan for CMSSW_14_1_X. It involves the following packages:
@Moanwar, @aloeliger, @cmsbuild, @epalencia, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Contributor
|
cms-bot internal usage |
Contributor
|
Thanks @skkwan |
Contributor
|
@skkwan , can you please open a PR for master branch (instead of CMSSW_14_1_X) |
Contributor
Author
|
Yes, I'll do that and close this one. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the out-of-bounds error in
Phase2L1RCT.hraised in #46372.PR description:
This PR addresses the out-of-bounds error in
Phase2L1RCT.hraised in #46372.PR validation:
The original emulator has been re-run and checked that the outputs are unchanged.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for: